Fix pipeline failures showing up as complete #1518
Merged
+26
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-phylum
previously approved these changes
Oct 10, 2024
maxrake
previously approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Reviewed code and confirmed with local testing:
❯ phylum --version
phylum v7.1.1
❯ phylum package pypi phylum 888.888.888
⚠️ Thank you for submitting this package. Please check back later for results.
❯ phylum package pypi phylum 888.888.888
Package Name: phylum Package Version: 888.888.888
License: Unknown Last updated: 1970-01-01T00:00:00+00:00
Num Deps: 0 Num Vulns: 0
Ecosystem: pypi
Risk Vectors:
Total Risk: 100
Author Risk: 100
Engineering Risk: 100
License Risk: 100
Malicious Code Risk: 100
Vulnerability Risk: 100
❯ target/debug/phylum --version
phylum v7.1.1-3-gd8b8889
❯ target/debug/phylum package pypi phylum 999.999.999
⚠️ Thank you for submitting this package. Please check back later for results.
❯ target/debug/phylum package pypi phylum 999.999.999
❗ Package analysis failed, please contact Phylum if this package exists.
This fixes an issue where packages would show up as passing Phylum's analysis if they failed at any point of the pipeline. Closes #351.
cd-work
dismissed stale reviews from maxrake and matt-phylum
The merge-base changed after approval.
maxrake
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where packages would show up as passing Phylum's
analysis if they failed at any point of the pipeline.
Closes #351.
Depends on #1517.